Skip to content

feat: allow epoch 3.3.0 in node config #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

feat: allow epoch 3.3.0 in node config #6584

merged 1 commit into from
Oct 23, 2025
+5 −0

Conversation

@hugoclrd
Copy link
Contributor

@hugoclrd hugoclrd commented Oct 9, 2025

Description

Allow setting the epoch 3.3 height in config, but don't make it mandatory

[[burnchain.epochs]]
epoch_name = "3.3"
start_height = 147

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@hugoclrd hugoclrd marked this pull request as ready for review October 9, 2025 18:01
@hugoclrd hugoclrd requested review from a team as code owners October 9, 2025 18:01
brice-stacks
brice-stacks reviewed Oct 9, 2025
View reviewed changes
obycode
obycode approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugoclrd hugoclrd mentioned this pull request Oct 10, 2025
Open
@brice-stacks brice-stacks added this pull request to the merge queue Oct 23, 2025
Merged via the queue into stacks-network:develop with commit 12188e3 Oct 23, 2025
3 of 4 checks passed
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.59%. Comparing base (a7f4240) to head (3dd4ac3).
⚠️ Report is 113 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/config/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6584      +/-   ##
===========================================
+ Coverage    71.12%   79.59%   +8.47%     
===========================================
  Files          568      568              
  Lines       347674   347671       -3     
===========================================
+ Hits        247267   276730   +29463     
+ Misses      100407    70941   -29466
Files with missing lines Coverage Δ
stackslib/src/config/mod.rs 69.45% <0.00%> (+4.34%) ⬆️

... and 304 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f4240...3dd4ac3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jcnelson jcnelson jcnelson approved these changes

@brice-stacks brice-stacks brice-stacks approved these changes

+1 more reviewer

@obycode obycode obycode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugoclrd @jcnelson @obycode @brice-stacks